Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: unify the usage of independent service #8508

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 9, 2024

What problem does this PR solve?

Issue Number: ref #8477.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 45.28302% with 29 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (92adb24) to head (21ac3a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8508      +/-   ##
==========================================
- Coverage   77.37%   77.37%   -0.01%     
==========================================
  Files         472      472              
  Lines       61828    61836       +8     
==========================================
+ Hits        47839    47844       +5     
- Misses      10420    10422       +2     
- Partials     3569     3570       +1     
Flag Coverage Δ
unittests 77.37% <45.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested a review from lhy1024 August 9, 2024 08:22
return false
}
return independent.(bool)
_, exist := c.independentServices.Load(name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need not to check the result?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@rleungx rleungx requested review from lhy1024 and HuSharp August 12, 2024 03:10
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 12, 2024
@@ -129,7 +129,7 @@ func (h *redirector) matchMicroServiceRedirectRules(r *http.Request) (bool, stri
for _, rule := range h.microserviceRedirectRules {
// Now we only support checking the scheduling service whether it is independent
if rule.targetServiceName == mcsutils.SchedulingServiceName {
if !h.s.IsServiceIndependent(mcsutils.SchedulingServiceName) {
if !h.s.GetRaftCluster().IsServiceIndependent(mcsutils.SchedulingServiceName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to unify mcsutils.SchedulingServiceName and utils.SchedulingServiceName as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8476 will change it to constant.xxx

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 03:14:39.922889657 +0000 UTC m=+151364.626359297: ☑️ agreed by lhy1024.
  • 2024-08-12 03:23:39.921960716 +0000 UTC m=+151904.625430359: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit 6b812c6 into tikv:master Aug 12, 2024
23 of 25 checks passed
@rleungx rleungx deleted the independent branch August 12, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants